Skip to content

fix(rust/cardano-chain-follower): Check condition for Block Roll Forward #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(rust/cardano-chain-follower): Check condition for Block Roll Forward #56

merged 2 commits into from
Oct 10, 2024

Conversation

@saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Oct 9, 2024 •
edited
Loading

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Closes input-output-hk/catalyst-engineering-internal#1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added bug review me PR is ready for review labels Oct 9, 2024
@saibatizoku saibatizoku self-assigned this Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 202/202}$ | ${\color{red}Fail: 0/202}$ |

@saibatizoku saibatizoku force-pushed the fix/roll-forward-condition branch from c6e912e to f13b703 Compare October 9, 2024 17:42
@saibatizoku saibatizoku requested a review from Mr-Leshiy October 9, 2024 17:50
minikin
minikin approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 1202a62 into main Oct 10, 2024
18 checks passed
@minikin minikin deleted the fix/roll-forward-condition branch October 10, 2024 13:22
@stevenj stevenj restored the fix/roll-forward-condition branch October 15, 2024 03:15
@stevenj
Copy link
Collaborator

stevenj commented Oct 15, 2024 •
edited
Loading

@saibatizoku This change requires a version bump of the package; otherwise we cannot tag a release for it, nor unambiguously refer to it as a dependency.

@saibatizoku saibatizoku deleted the fix/roll-forward-condition branch October 15, 2024 15:48
@saibatizoku saibatizoku mentioned this pull request Oct 15, 2024
Merged
8 tasks
@saibatizoku
Copy link
Contributor Author

saibatizoku commented Oct 15, 2024

@saibatizoku This change requires a version bump of the package; otherwise we cannot tag a release for it, nor unambiguously refer to it as a dependency.

Thanks, this PR bumps the package version. As soon as it's merged, I'll create a tag for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minikin minikin minikin approved these changes

@stevenj stevenj Awaiting requested review from stevenj

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy

Assignees

@saibatizoku saibatizoku

Labels

review me PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saibatizoku @stevenj @minikin